Skip to content

docs(mobile): Screens fork doc points at each archive's recorded source - #28293

Closed
only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m029
Closed

only21mil wants to merge 1 commit into
pingdotgg:mainfrom
only21mil:fix/audit-m029

Conversation

@only21mil

@only21mil only21mil commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Problem

docs/operations/mobile-screens-fork.md links the T3 Screens fork at tag t3-v5.0.0-t3.45. The app now ships react-native-screens-5.0.0-t3.48.tgz (#18492). So the link points at older source than the archive in apps/mobile/deps.

pingdotgg/react-native-screens now has a t3-v5.0.0-t3.48 tag at the archive's recorded commit, but no t3.46 or t3.47 tag. The t3.48 source and tag are on the fork named in that archive's t3-fork.json, as #18492's description links. The t3.45 archive also named a personal fork there, and pingdotgg/react-native-screens now has its t3-v5.0.0-t3.45 tag at the same commit. The link has been bumped by hand each time, once to a personal fork (#24206) and back (#24951).

Change

  • The link goes to the pingdotgg fork itself, with no version pinned.
  • The doc says t3-fork.json also records the source repository.
  • To reproduce an archive, check out the repository and commit that t3-fork.json records.

The doc then stays correct across Screens bumps, and nobody has to edit the link each time.

Scope and approval

This fixes a stale link in a maintainer doc, under the obvious-bug exception. It changes no code. The update steps still say to publish the tag to the fork. The missing t3.46 and t3.47 tags on pingdotgg/react-native-screens are for a maintainer to push. This PR doesn't change that process.

Verification

This is a maintainer doc, so no screen changes. I ran the checks below on main e63d80a (the newest main with green push CI), on this PR's head c472824, and on the head merged locally with that main (572350f65b, not pushed). All three ship the same t3.48 archive.

Before, on main e63d80a. The doc links tag t3.45, while the shipped archive is t3.48 and records a different repository:

$ git rev-parse HEAD
e63d80a06526ad624c92cb784152d034ed5ed6de
$ grep -n 'Screens fork' docs/operations/mobile-screens-fork.md
4:[T3 Screens fork](https://github.com/pingdotgg/react-native-screens/tree/t3-v5.0.0-t3.45).
$ tar -xzOf apps/mobile/deps/react-native-screens-5.0.0-t3.48.tgz package/t3-fork.json
{
  "repository": "https://github.com/PixPMusic/react-native-screens",
  "commit": "6ce484b346dd0d51e84566696a1b1a1af4dc6225",
  "upstreamCommit": "72f38a66c188bdebee7a7798c9b72a121b7a8451",
  "version": "5.0.0-t3.48"
}
$ git ls-remote --tags https://github.com/pingdotgg/react-native-screens 't3-v5.0.0-*' | grep -E 't3\.4[0-9]'
c9b07e550afd19773dbd7abf66c62b63d1ab9481	refs/tags/t3-v5.0.0-t3.43
830d18efbff569b28283b67bb03d330cb86f04e7	refs/tags/t3-v5.0.0-t3.43^{}
110d8cdc78c2afeb3e10132e1c19bbcf200b4dc7	refs/tags/t3-v5.0.0-t3.44
e70c651e670231635c4acb33d3f57c4238c300f6	refs/tags/t3-v5.0.0-t3.45
6ce484b346dd0d51e84566696a1b1a1af4dc6225	refs/tags/t3-v5.0.0-t3.48
$ curl -s -o /dev/null -w '%{http_code}\n' https://github.com/pingdotgg/react-native-screens/tree/t3-v5.0.0-t3.48
200

After, on head c472824. The link pins no version, the doc sends readers to the repository and commit the archive records, and that commit resolves:

$ git rev-parse HEAD
c472824ecc1dc782fa9722581f8f515fceb74327
$ sed -n '3,13p' docs/operations/mobile-screens-fork.md
The mobile v5 stack uses a committed tarball from the
[T3 Screens fork](https://github.com/pingdotgg/react-native-screens).
The fork owns the integration changes; the app does not patch this package.
Each archive includes compiled JavaScript, declarations, native source and
`t3-fork.json` recording its source repository, version, source commit and
upstream base.

To reproduce an archive, use Node 24 and the repository's pinned Yarn from a
clean checkout of the source repository and commit recorded in its
`t3-fork.json`:

$ git ls-remote https://github.com/PixPMusic/react-native-screens | grep 6ce484b346dd0d51e84566696a1b1a1af4dc6225
6ce484b346dd0d51e84566696a1b1a1af4dc6225	refs/heads/fix/android-routed-sheet-centering
6ce484b346dd0d51e84566696a1b1a1af4dc6225	refs/tags/t3-v5.0.0-t3.48^{}
$ curl -s -o /dev/null -w '%{http_code}\n' https://github.com/PixPMusic/react-native-screens/commit/6ce484b346dd0d51e84566696a1b1a1af4dc6225
200
$ curl -s -o /dev/null -w '%{http_code}\n' https://github.com/pingdotgg/react-native-screens
200
Full tag list on main, and the merged tree

Main e63d80a:

$ git rev-parse HEAD
e63d80a06526ad624c92cb784152d034ed5ed6de
$ git ls-remote --tags https://github.com/pingdotgg/react-native-screens 't3-v5.0.0-*'
da4c9b093b86aa36146133a437390f62a2f68b11	refs/tags/t3-v5.0.0-t3.1
1f9ae0dda920cfe39557e00806ae3d8b9d71b663	refs/tags/t3-v5.0.0-t3.1^{}
4b92b27af10918f1a2ed4ff30ee5f16eee046814	refs/tags/t3-v5.0.0-t3.17
d9b840b291cfb80f1f7856bf8e369faed03574ae	refs/tags/t3-v5.0.0-t3.2
b728d8ad713ac777187f799f265ea9601f29ff14	refs/tags/t3-v5.0.0-t3.2^{}
db6df4ca6f497c9e98e42327aebb7cd759d7dd72	refs/tags/t3-v5.0.0-t3.23
f16e7a93f84e00f2c93fd7875012cde6457ef578	refs/tags/t3-v5.0.0-t3.24
6a43d5261422444bc0bf8d984ce8a849bbeb01a5	refs/tags/t3-v5.0.0-t3.25
4dd10b619e8f25b13afd9b1d47895ad87f24d99a	refs/tags/t3-v5.0.0-t3.26
176ff64880ddd0a6122a1f18eda826479c8e73c7	refs/tags/t3-v5.0.0-t3.27
cd2a327d493aea42c57de33bb4a492caab42a029	refs/tags/t3-v5.0.0-t3.28
e99a726cc6e25791976674f17d1a7b580743e09e	refs/tags/t3-v5.0.0-t3.29
ad796d7e3de70c6830dc4e44397038ffd95fb0b2	refs/tags/t3-v5.0.0-t3.3
386fab20506da8759860fad5afa40cbd5a8b0f06	refs/tags/t3-v5.0.0-t3.30
37b3e3a52a6a48970576b2aa74f9554c4951c283	refs/tags/t3-v5.0.0-t3.31
e7137fa52fe7e4867ca0fd23cf5910d0cb2b4e0b	refs/tags/t3-v5.0.0-t3.32
5f282fe0d2c71c0e73495c1ff626c8e1e332e443	refs/tags/t3-v5.0.0-t3.33
67f258a1f9a75a77bc00c09bfee446a6ff0eadae	refs/tags/t3-v5.0.0-t3.34
2871cf38b1248bacbd56a3395ea45bc613a06e0d	refs/tags/t3-v5.0.0-t3.35
8edcc5cd97e0c32a3168da1130077bba9b107720	refs/tags/t3-v5.0.0-t3.36
0882966fac3b5b80dd32691618ef6ef4643fb813	refs/tags/t3-v5.0.0-t3.37
c9b07e550afd19773dbd7abf66c62b63d1ab9481	refs/tags/t3-v5.0.0-t3.43
830d18efbff569b28283b67bb03d330cb86f04e7	refs/tags/t3-v5.0.0-t3.43^{}
110d8cdc78c2afeb3e10132e1c19bbcf200b4dc7	refs/tags/t3-v5.0.0-t3.44
e70c651e670231635c4acb33d3f57c4238c300f6	refs/tags/t3-v5.0.0-t3.45
6ce484b346dd0d51e84566696a1b1a1af4dc6225	refs/tags/t3-v5.0.0-t3.48
e24d2002a64e8b1868ffb483b55500d29e313ddf	refs/tags/t3-v5.0.0-t3.7
a3e4c7a6806b14b0804ede1a0c01666725cc3d97	refs/tags/t3-v5.0.0-t3.8
$ curl -s -o /dev/null -w '%{http_code}\n' https://github.com/pingdotgg/react-native-screens/tree/t3-v5.0.0-t3.45
200

Head merged with main e63d80a (local, not pushed):

$ git rev-parse HEAD
572350f65b3ad8623f7ca506fd35ec9b8b6b41b1
$ git log -1 --format=%P HEAD
e63d80a06526ad624c92cb784152d034ed5ed6de c472824ecc1dc782fa9722581f8f515fceb74327
$ sed -n '3,13p' docs/operations/mobile-screens-fork.md
The mobile v5 stack uses a committed tarball from the
[T3 Screens fork](https://github.com/pingdotgg/react-native-screens).
The fork owns the integration changes; the app does not patch this package.
Each archive includes compiled JavaScript, declarations, native source and
`t3-fork.json` recording its source repository, version, source commit and
upstream base.

To reproduce an archive, use Node 24 and the repository's pinned Yarn from a
clean checkout of the source repository and commit recorded in its
`t3-fork.json`:

$ tar -xzOf apps/mobile/deps/react-native-screens-5.0.0-t3.48.tgz package/t3-fork.json
{
  "repository": "https://github.com/PixPMusic/react-native-screens",
  "commit": "6ce484b346dd0d51e84566696a1b1a1af4dc6225",
  "upstreamCommit": "72f38a66c188bdebee7a7798c9b72a121b7a8451",
  "version": "5.0.0-t3.48"
}
$ git ls-remote https://github.com/PixPMusic/react-native-screens | grep 6ce484b346dd0d51e84566696a1b1a1af4dc6225
6ce484b346dd0d51e84566696a1b1a1af4dc6225	refs/heads/fix/android-routed-sheet-centering
6ce484b346dd0d51e84566696a1b1a1af4dc6225	refs/tags/t3-v5.0.0-t3.48^{}
$ curl -s -o /dev/null -w '%{http_code}\n' https://github.com/PixPMusic/react-native-screens/commit/6ce484b346dd0d51e84566696a1b1a1af4dc6225
200

CI's Check job passes on c472824.

Not checked:

  • No archive rebuild from the recorded source.

Prior PRs

#18433 by juliusmarminge pointed this doc at the pingdotgg fork, and this keeps that. #18492 by PixPMusic shipped t3.48. I found no open PR that touches this file.

Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly

The doc linked the pingdotgg fork's t3-v5.0.0-t3.45 tag while the app ships 5.0.0-t3.48, whose source and tag live on the contributor fork named in its t3-fork.json. Link the fork itself and send readers to the repository and commit that t3-fork.json records, so the doc stays true across Screens bumps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 31, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c472824

Macroscope's review found this PR approvable — The documentation now directs archive reproduction to the source repository and commit recorded in each archive instead of a fixed fork tag. No runtime behavior, product defaults, or diagnostic suppressions change.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The Mobile Screens fork documentation now links to the repository, describes the source repository in archive metadata, and instructs readers to reproduce from the source repository and commit recorded in t3-fork.json.

Changes: Mobile Screens fork documentation

Layer / File(s) Summary
Archive source and reproduction guidance
docs/operations/mobile-screens-fork.md
The fork link points to the repository. Archive metadata includes the source repository. Reproduction instructions use a clean checkout of the source repository and commit recorded in t3-fork.json.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to c4728

The documentation change has no identified merge-blocking issue.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly and concisely describes the documentation change: it points the Screens fork documentation to each archive’s recorded source.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections. The problem is clear: the doc links tag t3-v5.0.0-t3.45, but the shipped archive…
Full details: Description check

Explanation

The description follows the repository template. It has Problem, Change, Scope and approval, and Verification sections. The problem is clear: the doc links tag t3-v5.0.0-t3.45, but the shipped archive is t3.48 and records a different source repository. The change is also clear: the link now points to the pingdotgg fork with no pinned version, and reproduction steps now use the repository and commit recorded in t3-fork.json. The scope section claims the obvious-bug exception and explains why it applies, since the change is a stale doc link with no code changes. Verification gives concrete commands and observed outputs on main, on the PR head, and on the merged tree, and it states what was not checked (no archive rebuild). The template's agent-attribution line is present at the end. Minor gaps: the verification section is long, and the description does not restate the CONTRIBUTING.md reference, but these are non-critical.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 15fe283 and c472824.

Files selected for processing: 1

  • docs/operations/mobile-screens-fork.md

Limit details: You’ve used all 10 included reviews currently available.

@only21mil

Copy link
Copy Markdown
Contributor Author

Note

🤖 Opus 5.5 replying on behalf of Victor.

Closing this to bring my open PRs down under the new limit. The branch stays on my fork if it is useful.

@only21mil only21mil closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant