Repository navigation
Conversation
The doc linked the pingdotgg fork's t3-v5.0.0-t3.45 tag while the app ships 5.0.0-t3.48, whose source and tag live on the contributor fork named in its t3-fork.json. Link the fork itself and send readers to the repository and commit that t3-fork.json records, so the doc stays true across Screens bumps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — The documentation now directs archive reproduction to the source repository and commit recorded in each archive instead of a fixed fork tag. No runtime behavior, product defaults, or diagnostic suppressions change. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Note 🤖 Opus 5.5 replying on behalf of Victor. Closing this to bring my open PRs down under the new limit. The branch stays on my fork if it is useful. |
Problem
docs/operations/mobile-screens-fork.mdlinks the T3 Screens fork at tagt3-v5.0.0-t3.45. The app now shipsreact-native-screens-5.0.0-t3.48.tgz(#18492). So the link points at older source than the archive inapps/mobile/deps.pingdotgg/react-native-screens now has a
t3-v5.0.0-t3.48tag at the archive's recorded commit, but not3.46ort3.47tag. The t3.48 source and tag are on the fork named in that archive'st3-fork.json, as #18492's description links. The t3.45 archive also named a personal fork there, and pingdotgg/react-native-screens now has itst3-v5.0.0-t3.45tag at the same commit. The link has been bumped by hand each time, once to a personal fork (#24206) and back (#24951).Change
t3-fork.jsonalso records the source repository.t3-fork.jsonrecords.The doc then stays correct across Screens bumps, and nobody has to edit the link each time.
Scope and approval
This fixes a stale link in a maintainer doc, under the obvious-bug exception. It changes no code. The update steps still say to publish the tag to the fork. The missing
t3.46andt3.47tags on pingdotgg/react-native-screens are for a maintainer to push. This PR doesn't change that process.Verification
This is a maintainer doc, so no screen changes. I ran the checks below on main e63d80a (the newest main with green push CI), on this PR's head c472824, and on the head merged locally with that main (572350f65b, not pushed). All three ship the same t3.48 archive.
Before, on main e63d80a. The doc links tag t3.45, while the shipped archive is t3.48 and records a different repository:
After, on head c472824. The link pins no version, the doc sends readers to the repository and commit the archive records, and that commit resolves:
Full tag list on main, and the merged tree
Main e63d80a:
Head merged with main e63d80a (local, not pushed):
CI's Check job passes on c472824.
Not checked:
Prior PRs
#18433 by juliusmarminge pointed this doc at the pingdotgg fork, and this keeps that. #18492 by PixPMusic shipped t3.48. I found no open PR that touches this file.
Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly